Child process should ignore files that are specified in the ignore array #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasong689
force-pushed
the
child-process-ignore
branch
from
5f0e144
to
5b30ac2
Compare
jasong689
commented
May 19, 2023
| @@ -166,4 +174,6 @@ export const wds = async (options: RunOptions) => { | |||
| logShutdown("shutting down project since it's no longer needed..."); | |||
| project.shutdown(code ?? 1); | |||
| }); | |||
|
|
|||
| return server; | |||
There was a problem hiding this comment.
Needed to return the server here so that I could close it in my tests
jasong689
commented
May 19, 2023
| await this.reportErrors(async () => { | ||
| await Promise.all(fileNames.map((filename) => this.buildFile(filename, root, swcConfig))); | ||
| }); | ||
| await this.reportErrors(Promise.allSettled(fileNames.map((filename) => this.buildFile(filename, root, swcConfig)))); |
There was a problem hiding this comment.
I wasn't entirely sure if this was a bug or not. Files will stop compiling as soon as one file fails with Promise.all, this was fixed so that the benchmarks could be run
airhorns
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the child process will attempt to get the parent process to compile a file even if it's part of your
wds.ignoredpath. This results in "[wds] Internal error: compiled ${filename} but did not get it returned from the leader process in the list of compiled files" being thrown on these files. Checking if the file was ignored in the child process was much too slow and almost tripled the bench results so instead we'll return if the file is ignored from the parent call.